[alsa-devel] [PATCH] ALSA: have snd_BUG_ON() always refer to arguments
vapier.adi at gmail.com
Fri Nov 7 11:03:10 CET 2008
On Fri, Nov 7, 2008 at 04:56, Takashi Iwai wrote:
> At Fri, 7 Nov 2008 04:30:43 -0500, Mike Frysinger wrote:
>> we arent talking about assert() here nor are we talking about assert()
>> behavior, but i would say it was a poor decision. the fact that it's
>> called snd_BUG_ON() instead of snd_WARN_ON() is also a bit broken imo.
>> BUG() kills the kernel while WARN() complains, and snd_BUG_ON() is
>> clearly in the latter category.
> Right, that's a bit confusing. It came because we had already
> snd_BUG() macro. I took snd_BUG_ON() from the analogy of snd_BUG().
>> that said, you could just define snd_BUG_ON() in terms of WARN_ON()
>> all the time:
> Hm, this looks a good alternative, too.
> Though, this was already fixed on my git tree in another way...
np. if it's fixed now, i'm happy. maybe keep in mind my suggestion
if someone else complains about the current code not working for them
thanks for your help.
More information about the Alsa-devel