[alsa-devel] [PATCH 1/4] ASoC: TLV320AIC23B Support more sample rates

Takashi Iwai tiwai at suse.de
Thu Nov 6 12:03:59 CET 2008


At Thu, 6 Nov 2008 10:49:06 +0000,
Mark Brown wrote:
> 
> On Wed, Nov 05, 2008 at 09:35:01PM +0100, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > +		return score;
> 
> > > +	return 0xffffffff;
> 
> > -1 would be simpler and safer (for possible missing f's).
> 
> I'm not sure that'd add to the clarity - the goal isn't to have all bits
> set, the goal is to have a much larger score than could ever otherwise
> be achieved so putting in a very large constant expresses that much more
> directly.

In that case, the best form is UINT_MAX.


Takashi


More information about the Alsa-devel mailing list