[alsa-devel] [PATCH] alsa-info.sh - Fixed typo that stops the 'Automatic Upload' warning from appearing.

Travis Place wishie at wishie.net
Mon May 19 18:10:44 CEST 2008


On Mon, 19 May 2008 12:08:30 am Travis Place wrote:
> Fixed a typo that was causing no warning about the script automatically
> uploading info to a pastebin. Some users were NOT too happy with this.
>
> Also, bumped up the version number so existing versions will automatically
> update to the fixed version upon next script run.
>
>
> diff -r 93548f7b2086 alsa-info.sh
> --- a/alsa-info.sh	Wed Apr 30 14:47:42 2008 +0200
> +++ b/alsa-info.sh	Mon May 19 00:01:04 2008 +1000
> @@ -1,6 +1,6 @@
>  #!/bin/bash
>
> -SCRIPT_VERSION=0.4.43
> +SCRIPT_VERSION=0.4.44
>  CHANGELOG="http://hg.alsa-project.org/alsa/log/tip/alsa-info.sh"
>
>
> ###########################################################################
>###### @@ -215,7 +215,7 @@ if [ "$QUESTION" = "yes" ]; then
>  if [ "$QUESTION" = "yes" ]; then
>  if [[ -n "$DIALOG" ]]
>  then
> -if [ -z "NOUPLOAD" ]; then
> +if [ -z "$NOUPLOAD" ]; then
>  	dialog --backtitle "$BGTITLE" --title "ALSA-Info script v
> $SCRIPT_VERSION" --yesno "\nThis script will collect information about your
> ALSA installation and sound related hardware, to help diagnose your
> problem\n\nBy default, this script will AUTOMATICALLY UPLOAD your
> information to a pastebin site.\n\nSee $0 --help for options\n\nDo you want
> to run this script?" 0 0
>  else
>  	dialog --backtitle "$BGTITLE" --title "ALSA-Info script v
> $SCRIPT_VERSION" --yesno "\nThis script will collect information about your
> ALSA installation and sound related hardware, to help diagnose your
> problem\n\nSee $0 --help for options\n\nDo you want to run this script?" 0
> 0
>
>
> Thanks,
> Travis Place
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Did this one get overlooked ? Its a pretty serious issue to some people, if 
you upload info without warning them.

Travis Place

-- 
Happiness is like peeing your pants. Everyone can see it, but only you can 
feel its warmth 


More information about the Alsa-devel mailing list