[alsa-devel] [PATCH, RFC] ASoC: uda1380 cleanup

Liam Girdwood lg at opensource.wolfsonmicro.com
Sat May 10 15:48:16 CEST 2008

On Sat, 2008-05-10 at 15:25 +0200, Philipp Zabel wrote:
> This patch mostly consists of (mostly checkpatch) cleanups, removal of
> the custom dbg macro and uda1380_snd_soc_cnew, which doesn't seem to
> be
> needed anymore. I also removed the hardcoded WinCE/magician register
> values from uda1380_pcm_prepare. Still, a number of FIXMEs remain.
> Signed-off-by: Philipp Zabel <philipp.zabel at gmail.com>
> ---
>  sound/soc/codecs/uda1380.c |  252
> ++++++++++++++++++++++----------------------
>  1 files changed, 128 insertions(+), 124 deletions(-)

Thanks, applied to ASoC git.

Fwiw, the FIXMEs all look relatively minor and have been worked around
in the driver (although I don't have Magician hardware to test this).
Are any of them showstoppers for upstream ?  


More information about the Alsa-devel mailing list