[alsa-devel] PATCH - ESI Juli driver - works OK
pavel.hofman at insite.cz
Tue Mar 18 20:24:40 CET 2008
Takashi Iwai wrote:
> At Tue, 18 Mar 2008 07:56:11 +0100,
> Pavel Hofman wrote:
>> Takashi Iwai wrote:
>>> At Mon, 17 Mar 2008 16:50:39 +0100,
>>> Pavel Hofman wrote:
>>> Well, then we'll need to find some point to compromise. Could you
>>> repost the patch after reducing the callbacks again?
>>> I'll have also no time from the next week at all -- will be on
>>> vacation for three weeks. So, let's kick it out soonish :)
>> I am sorry, the previous patch had some debugs enabled. Here is a fixed
>> Thanks a lot.
>> Signed-off-by: Pavel Hofman <dustin at seznam.cz>
>> * moving most of clock-specific code to card-specific routines
>> * support for ESI Juli
>> * to-be-researched - monitoring of analog/digital inputs
> Thanks. Now I checked the patch and found it much better now.
> However, I still think the get_rate_index can be omitted by checking
> the index from the rate list dynamically. This looks inefficent but
> improves the readability and reduces the code size better. Moreover,
> the snd_pcm_hw's aren't needed to be prepared for each type.
> Below is my revised patch. With this patch, ice->hw_rates must be
> non-NULL and this is referred in many places. It cleans up
> *_internal_clock*() nicely.
Well Takashi, you are the real master here, your patch tells. I
especially like the smart way you replaced the ugly switch/case
structures in juli.c
The patch works fine, both standard clock as well as Juli.
Thanks a lot for your major help. Now time to move on to another audiobeast.
More information about the Alsa-devel