[alsa-devel] PATCH - ESI Juli driver
pavel.hofman at insite.cz
Mon Mar 17 15:08:48 CET 2008
Takashi Iwai wrote:
> At Mon, 17 Mar 2008 10:37:22 +0100,
> Pavel Hofman wrote:
>> What would you recommend?
> IMO, rate_code can be avoided. Instead of exposing the encoded value,
> better to use the raw rate value as parameters.
No problem. I just wanted to avoid the repeated conversion from the
numerical rate to the card specific representation which is input
information for all the rate-related code. ice1724 cards utilize
MT_RATE, juli makes use of GPIO.
If you are OK with the repeated conversion, I will remove this. I tried
to keep the methods inline if possible.
> And, the texts inf rates_info can be generated dynamically.
For obvious reasons I tried changing ice1724 as little as possible. That
is why I kept the original code, only rearranged it.
I can change the way texts in rates_info are generated. Still there will
have to be some callback as juli has a different list of rates.
> So, what we need primarily are callbacks to get and set the current
> rate setting. Suppose rate=0 as SPDIF-in, we can pass the raw rate
> value. Then snd_vt1724_pro_internal_clock_get() would just a function
> to get the current rate and compares it with the given rate_info
> value, returns the index.
I am afraid I do not understand what to change in
snd_vt1724_pro_internal_clock_get(). It seems fairly logical, I made
only minor changes - is_spdif_master used in other parts of the code,
get_rate_index with a simple meaning.
> How to set stream-specific hw_params is another question. But surely
> we can cut off a bit more.
We probably can, by rewriting portions of the original well-tested
ice1724 code. I really wanted to avoid that and changed by callbacks
only the card-specific portions.
OK, I will remove the rate_code conversions, the new overhead will be
low and one abstraction will be removed.
For the rest, please state you objectives. Either cutting a few of the
callbacks by non-trivial rewrite of the original ice1724 code, or
keeping the remaining callbacks and the well-tested code.
Thanks a lot,
Rubesova 29, 326 00 Plzen
Tel., fax: +420 - 37 - 74 493 58
GSM: +420 - 603 - 163 973
Email: pavel.hofman at insite.cz
Navstivte www.educity.cz, server
s nejvetsi nabidkou profesniho
vzdelavani na ceskem internetu.
More information about the Alsa-devel