[alsa-devel] Same pci id for different ASUS machine

[Takashi Iwai]

At Thu, 13 Mar 2008 10:48:49 +0800,
Jiang zhe wrote:
> 
> Hi,
> 
> According to the [0003839]
> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3839
> 
> The PCI ID of ASUS F9S is 1043:1339 and "model=lenovo" works for it.
> But I found that ASUS G1 have the same id and model is 3stack in the
> alsa driver.
> 
> Which one is true?

The question is rather which one is "better".  At the time ASUS G1
quirk was added, there was no lenovo model preset.  If lenovo preset
works better, we should take it, as the devices with the same PCI SSID
are supposed to be compatible.


Takashi


> --- alsa-driver-hg20080313/alsa-kernel/pci/hda/patch_realtek.c
> 2008-03-13 09:00:08.000000000 +0800
> +++ b/alsa-kernel/pci/hda/patch_realtek.c	2008-03-13 10:38:57.000000000
> +0800
> @@ -12591,7 +12591,7 @@ static struct snd_pci_quirk alc861vd_cfg
>  	SND_PCI_QUIRK(0x1019, 0xa88d, "Realtek ALC660 demo", ALC660VD_3ST),
>  	SND_PCI_QUIRK(0x103c, 0x30bf, "HP TX1000", ALC861VD_HP),
>  	SND_PCI_QUIRK(0x1043, 0x12e2, "Asus z35m", ALC660VD_3ST),
> -	SND_PCI_QUIRK(0x1043, 0x1339, "Asus G1", ALC660VD_3ST),
> +	SND_PCI_QUIRK(0x1043, 0x1339, "Asus F9S", ALC861VD_LENOVO),
>  	SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS", ALC660VD_3ST_DIG),
>  	SND_PCI_QUIRK(0x10de, 0x03f0, "Realtek ALC660 demo", ALC660VD_3ST),
>  	SND_PCI_QUIRK(0x1179, 0xff00, "Toshiba A135", ALC861VD_LENOVO),
> 
> [2 asus_F9s_alc861vd.patch <text/x-patch; UTF-8 (7bit)>]
> --- alsa-driver-hg20080313/alsa-kernel/pci/hda/patch_realtek.c	2008-03-13 09:00:08.000000000 +0800
> +++ b/alsa-kernel/pci/hda/patch_realtek.c	2008-03-13 10:38:57.000000000 +0800
> @@ -12591,7 +12591,7 @@ static struct snd_pci_quirk alc861vd_cfg
>  	SND_PCI_QUIRK(0x1019, 0xa88d, "Realtek ALC660 demo", ALC660VD_3ST),
>  	SND_PCI_QUIRK(0x103c, 0x30bf, "HP TX1000", ALC861VD_HP),
>  	SND_PCI_QUIRK(0x1043, 0x12e2, "Asus z35m", ALC660VD_3ST),
> -	SND_PCI_QUIRK(0x1043, 0x1339, "Asus G1", ALC660VD_3ST),
> +	SND_PCI_QUIRK(0x1043, 0x1339, "Asus F9S", ALC861VD_LENOVO),
>  	SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS", ALC660VD_3ST_DIG),
>  	SND_PCI_QUIRK(0x10de, 0x03f0, "Realtek ALC660 demo", ALC660VD_3ST),
>  	SND_PCI_QUIRK(0x1179, 0xff00, "Toshiba A135", ALC861VD_LENOVO),