[alsa-devel] [PATCH 2/2] ad1848: replace duplicated constants in cs4231

Krzysztof Helt krzysztof.h1 at poczta.fm
Thu Jun 19 19:56:39 CEST 2008

On Thu, 19 Jun 2008 11:10:00 +0200
Takashi Iwai <tiwai at suse.de> wrote:

> At Sun, 15 Jun 2008 12:41:28 +0200,
> Krzysztof Helt wrote:
> > 
> > From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> > 
> > Use AD1848 register names in the cs4231 library as well.
> > 
> > Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
> Please fix to be checkpatch.pl clean at the next repost.
> WARNING: line over 80 characters
> #438: FILE: sound/isa/cs423x/cs4231_lib.c:525:
> +		snd_cs4231_dout(chip, AD1848_LEFT_INPUT, chip->image[AD1848_LEFT_INPUT]);
> ...
> total: 0 errors, 60 warnings, 1319 lines checked

I have fixed all errors except too long lines, because most of them are in
the macros CS4231_DOUBLE and CS4231_SINGLE (mixer elements definitions).
Should I break these definitions as well?

I have gone berserk with the changes and done three patches till now:
1. Move isa/cs423x/cs4231_lib.c to isa/wss/wss_lib.c
2. Renamed cs4231.h to wss.h
3. Renamed all cs4231_lib function cs4231_foo() into wss_foo().

The next step is to use snd_wss (former snd_cs4231) into the ad1848_lib
functions then slowly assimilate the whole ad1848_lib into the wss_lib.

Question: should I also fix any checkpatch errors/warnings in the first
two patches (move file and rename file)?


Gdzie warto jechac na urlop? Sprawdz!
kliknij >>> http://link.interia.pl/f1e32

More information about the Alsa-devel mailing list