[alsa-devel] [PATCH 1/2] ASoC: Check for exact register match in wm97xx_reset()

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Jun 13 17:19:02 CEST 2008

On Fri, Jun 13, 2008 at 05:11:06PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> >  	soc_ac97_ops.reset(codec->ac97);
> > -	if (ac97_read(codec, 0) & 0x8000)
> > +	if (ac97_read(codec, 0) != 0x6174)

> Can we define this magic value more understandable?

It's the default value for the (non-modifiable) register - building it
up from a bitmask with semantics isn't particularly meaningful.  The
only thing I can think is to just reference the register cache default
values, I'll resend in a minute or two.

More information about the Alsa-devel mailing list