[alsa-devel] ALSA 1.0.17rc1 release

[Alan Horstmann]

On Friday 13 June 2008 12:08, Alan Horstmann wrote:
> On Friday 13 June 2008 11:16, I wrote:
> > Build problem with released 1.0.17rc1 driver package on kernel 2.4.21-99
> > (Suse9.0):
> >
> > Compiling all modules:
> >
> > ld  -r -o snd-ens1370.o ens1370.o ak4531_codec.o
> > ak4531_codec.o(.modinfo+0x40): multiple definition of `__module_author'
> > ens1370.o(.modinfo+0x40): first defined here
> > ld: Warning: size of symbol `__module_author' changed from 79 in
> > ens1370.o to 40 in ak4531_codec.o
> > ak4531_codec.o(.modinfo+0x80): multiple definition of
> > `__module_description' ens1370.o(.modinfo+0xa0): first defined here
> > ld: Warning: size of symbol `__module_description' changed from 36 in
> > ens1370.o to 48 in ak4531_codec.o
> > make[1]: *** [snd-ens1370.o] Error 1
> > make[1]: Leaving directory
> > `/usr/share/alsa1.0.17rc1/alsa-driver-1.0.17rc1/ pci'
> > make: *** [compile] Error 1
> >
> > Compiling my usual au8820,ice1712,ymfpci:
> >
> > make[2]: Entering directory
> > `/usr/share/alsa1.0.17rc1/alsa-driver-1.0.17rc1/ pci/ac97'
> > make[2]: *** No rule to make target `ak4531_codec.c', needed by
> > `ac97_codec.o'.  Stop.
> > make[2]: Leaving directory
> > `/usr/share/alsa1.0.17rc1/alsa-driver-1.0.17rc1/ pci/ac97'
> > make[1]: *** [_modsubdir_ac97] Error 2
> > make[1]: Leaving directory
> > `/usr/share/alsa1.0.17rc1/alsa-driver-1.0.17rc1/ pci'
> > make: *** [compile] Error 1
>
> The second can be fixed with the following patch, but I don't know if it's
> correct (ie there was a typo) or just works in this case but breaks
> elsewhere.
>
> --- pci/ac97/Makefile-orig	2008-06-06 09:54:06.000000000 +0100
> +++ pci/ac97/Makefile	2008-06-13 11:47:02.000000000 +0100
> @@ -6,7 +6,7 @@
>  include $(SND_TOPDIR)/Makefile.conf
>
>  clean-files := ac97_codec.c
> -export-objs  := ac97_codec.o ac97_pcm.o ak4531_codec.o
> +export-objs  := ac97_codec.o ac97_pcm.o
>
>  include $(SND_TOPDIR)/alsa-kernel/pci/ac97/Makefile


Think I may have grasped what has happened here (correct me if wrong).

Previously ak4531_codec.o was build to a module snd-ak4531-codec (similar to 
snd-ice17xx-ak4xxx) but for some reason resided in /pci/ac97 directory.  Now 
it has been moved to /pci, but the Makefiles do not create a separate module, 
but attempt to build it into snd-ens1370, where the conflict of author and 
description occur.  If those are //out of ak4531_codec.c then the build does 
continue through this (to another error -dealing with separately), and there 
is no separate module.  To create a separate module instead, presumably the 
Makefiles need to be fixed, and the module dependancies?

Which is the prefered arrangement?

Alan