[alsa-devel] [PATCH 1/3] ASoC: Add WM8510 driver
broonie at opensource.wolfsonmicro.com
Thu Jun 5 10:47:32 CEST 2008
On Wed, Jun 04, 2008 at 11:38:19PM +0200, Takashi Iwai wrote:
> OK. I just wanted to confirm since the patch had no extra From: line
> although the comment in the code shows Liam as the author.
Ideally we'd be able to merge the full history.
> This is likely superfluous.
> > +#include <sound/initval.h>
Needed for SNDRV_DEFAULT_IDX1 and SNDRV_DEFAULT_STR1.
> > + codec->reg_cache_size = sizeof(wm8510_reg);
> Isn't this ARRAY_SIZE()? Looks like the all codec codes set the wrong
> values for this...
Not all, but most.
More information about the Alsa-devel