[alsa-devel] [PATCH] Revised AT32 ASoC Patch

[Geoffrey Wossum]

On Wednesday 04 June 2008 08:28:07 am Mark Brown wrote:
> On Wed, Jun 04, 2008 at 02:01:55PM +0200, Takashi Iwai wrote:
> > Geoffrey Wossum wrote:
> > > +struct at32_ssc_info {
> > > +	char *name;
> > > +	struct ssc_device *ssc;
> > > +	spinlock_t lock;	/* lock for dir_mask */
> >
> > Just wondering whether this lock is really needed.
> > Is it really racy?
>
> Bidirectional ports could be in two PCMs and have configuration
> happening simultaneously.

To be honest, the AT91 code I was porting to the AT32 had this lock.  I think 
Mark is correct, so it's probably good I wasn't writing this code from 
scratch since I might have missed this detail on the first pass.

---
Geoffrey