[alsa-devel] [PATCH 10/10] wss_lib: use wss detection code instead of ad1848 one

Rene Herman rene.herman at keyaccess.nl
Tue Jul 29 16:37:08 CEST 2008


On 29-07-08 16:31, Takashi Iwai wrote:

>> 2) debug printks
>>
>> For one example here, see:
>>
>> http://mailman.alsa-project.org/pipermail/alsa-devel/2008-July/008978.html
>>
>> /snd_wss_debug
>>
>> Bad, bad, triply bad.
> 
> This change is actually buggy.  Each second printk should have no
> KERN_* prefix.  KERN_* prefix is only for the beginning of the line.

See how these formatting "fixes" made me miss that? ;-)

> A more better fix would be to rewrite this to use a loop, BTW.

Rene.



More information about the Alsa-devel mailing list