[alsa-devel] [PATCH] Permit simultaneous compilation of both PXA AC97 drivers

Liam Girdwood lg at opensource.wolfsonmicro.com
Sat Jul 26 14:22:34 CEST 2008

On Sat, 2008-07-26 at 12:06 +0100, Mark Brown wrote:
> On Sat, Jul 26, 2008 at 02:15:17AM +0400, Dmitry Baryshkov wrote:
> > I should have said, that these patches are largely untested. Please test
> > before applying.
> Yeah, unfortunately it's kind of hard to get good test coverage due to
> the number of variants :/ .  On the basis of the diffs these patches
> look good, though the volume of code motion means that I'll do another
> pass later.  I'll also test with the hardware I have and then push up to
> Takashi (assuming I don't spot any issues) - it may be the middle of
> next week before that happens.  Other test reports would be appreciated.
> This is certainly a very welcome cleanup - thanks a lot for doing it!

Agreed, thanks for the cleanup. :)

However this really *must* be tested on all pxa variants before
upstreaming. The pxa family all have slightly different AC97 controller
hardware (and quirks) and subsequently it may work fine on your board
but break others :-/

We can certainly test on pxa270 and pxa320. Can someone else do the
other variants.

Btw, the tests should also include AC97 slot 12 IO. i.e read and write
codec register 0x54.



More information about the Alsa-devel mailing list