[alsa-devel] [PATCH] V3, Convert bitfields in ASOC into full int width

Jon Smirl jonsmirl at gmail.com
Wed Jul 23 23:24:26 CEST 2008

On 7/23/08, Mark Brown <broonie at opensource.wolfsonmicro.com> wrote:
> On Wed, Jul 23, 2008 at 03:56:44PM -0400, Jon Smirl wrote:
>  > Convert bitfields in ASOC into full int width. This is a
>  > simple mechanical conversion. Two places in the DAPM code
>  > were fixed to properly use mask. Missing header for
>  > dapm_reg_event added. All codecs can build.
> AFAICT there are no substantial changes on top of what I already applied?

There are two more fixes in there in addition to the \.

tlv320aic3x uses a macro that exposed this missing header:

 /* dapm events */
+int dapm_reg_event(struct snd_soc_dapm_widget *w,
+                  struct snd_kcontrol *kcontrol, int event);
 int snd_soc_dapm_stream_event(struct snd_soc_codec *codec, char *stream,
       int event);
 int snd_soc_dapm_set_bias_level(struct snd_soc_device *socdev,

And this one in my changes that I missed:

       .put = snd_soc_put_volsw, \
       .private_value = (unsigned long)&(struct soc_mixer_control) \
-               {.reg = xreg, .shift = shift_left, .rshift = right_shift, \
+               {.reg = xreg, .shift = shift_left, .rshift = shift_right, \
                .max = xmax, .invert = xinvert} }
Jon Smirl
jonsmirl at gmail.com

More information about the Alsa-devel mailing list