[alsa-devel] [PATCH] V2, Convert bitfields in ASOC into full int width

[Jon Smirl]

On 7/23/08, Mark Brown <broonie at opensource.wolfsonmicro.com> wrote:
> On Wed, Jul 23, 2008 at 01:43:02PM -0400, Jon Smirl wrote:
>  > Convert bitfields in ASOC into full int width. This is a
>  > simple mechanical conversion. Two places in the DAPM code
>  > were fixed to properly use mask.
>
>
>   CHECK   sound/soc/soc-core.c
>  include/sound/soc.h:71:4: error: Expected ; end of type declaration
>  include/sound/soc.h:71:4: error: got .
>  sound/soc/soc-core.c:295:6: error: undefined identifier 'SND_SOC_BIAS_PREPARE'
>  sound/soc/soc-core.c:308:6: error: undefined identifier 'SND_SOC_BIAS_STANDBY'
>  sound/soc/soc-core.c:369:7: error: undefined identifier 'SND_SOC_BIAS_STANDBY'
>  sound/soc/soc-core.c:441:28: error: undefined identifier 'SND_SOC_BIAS_ON'
>  sound/soc/soc-core.c:444:11: error: undefined identifier 'SND_SOC_BIAS_PREPARE'
>  sound/soc/soc-core.c:455:40: error: undefined identifier 'SND_SOC_BIAS_ON'
>   CC      sound/soc/soc-core.o
>  In file included from sound/soc/soc-core.c:34:
>  include/sound/soc.h:71: error: expected identifier or '(' before '.' token
>  include/sound/soc.h:71: error: expected identifier or '(' before '}' token
>
>  The fix was trivial enough so I've made and applied it (and done some
>  brief testing of my own) - please be more careful in future.

I did that making checkpatch happy. I don't have easily buildable test
cases for powerpc so I'm doing this via inspection.  I'll see if I can
mess with Kconfig and force all of the codecs to build.

So this one is ok with the \ added? Next round I need to clean
everything up to make it 32 bit safe instead of only 16 bit. It will
probably touch some of the same code and needs to apply on top of this
patch.

-- 
Jon Smirl
jonsmirl at gmail.com