[alsa-devel] [PATCH] PalmTX aSoC sound support

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Jul 18 17:23:11 CEST 2008

On Fri, Jul 18, 2008 at 05:13:09PM +0200, Takashi Iwai wrote:
> At Fri, 18 Jul 2008 15:49:20 +0100,
> Russell King - ARM Linux wrote:
> > The reason for this is simple - if I push a new tree out, the nice diff
> > versions for non-git users of my tree will vanish, despite there being
> > changes still in there, and I don't want a flood of "where's my changes
> > gone?  they aren't in Linus' tree and they aren't in the diffs."
> > questions.
> Well, changes over several areas are sometimes painful.

It doesn't have to be - in this particular instance is down to patch
5088/3, which introduced a new #include into pcm027.c, where the file
to be included is in the SPI tree.

In hind sight, that change should've been separated into two patches:
1. create the new API and change existing users over
2. add new pcm027 support (reliant on SPI tree)

This would've meant that things could have been arranged so that the
_only_ outstanding patch was (2) rather than the existing situation
where quite a lot of other peoples changes are currently stuck
(because they inadvertently and indirectly depend on (1)).

That's something to watch in the future...

More information about the Alsa-devel mailing list