[alsa-devel] [boot crash, bisected] in 9f240a55 "ALSA: opti93x: use cs4231 lib"

Rene Herman rene.herman at keyaccess.nl
Fri Jul 18 14:39:08 CEST 2008

On 18-07-08 14:36, Rene Herman wrote:

> On 18-07-08 14:28, Krzysztof Helt wrote:
>> On Fri, 18 Jul 2008 11:19:19 +0200
>> Rene Herman <rene.herman at keyaccess.nl> wrote:
>>> On 17-07-08 21:38, Rene Herman wrote:
>>>> On 17-07-08 21:20, Rene Herman wrote:
>>>>> On 17-07-08 20:40, Takashi Iwai wrote:
>>>>>> Could you try the patch below?
>>> This bug was uncovered by !CONFIG_PNP and we had trouble in this 
>>> driver due to that before so was rewriting the init to be a generic 
>>> multi-card ALSA init but, actually, not much point.
>> The bug was introduced by the patch as it used (tried to free) the 
>> codec pointer
>> before it was assigned any value. It happened only if the card was 
>> missing and
>> I didn't test the driver on such a configuration. My mistake. The 
>> setting makes no difference.
> Yes it does. Note how the ISA match method fails due to "if (isapnp)" 
> with CONFIG_PNP and isapnp being initialized to 1. I did test without 
> the hardware but didn't see it fail due to that.

(but please note, yes, "uncovered", not "caused". the bug was indeed in 
this commit and was fixed by Takashi).


More information about the Alsa-devel mailing list