[alsa-devel] [PATCH] ALSA: ac97: copy subsys values from the PCI device

Takashi Iwai tiwai at suse.de
Thu Jul 17 14:26:46 CEST 2008


At Thu, 17 Jul 2008 14:24:32 +0200,
Rene Herman wrote:
> 
> >From 01de5a42c7d5a0237895a476735028298203f30f Mon Sep 17 00:00:00 2001
> From: Rene Herman <rene.herman at gmail.com>
> Date: Thu, 17 Jul 2008 14:18:10 +0200
> Subject: [PATCH] ALSA: ac97: copy subsys values from the PCI device
> 
> copy the subsys values from the PCI device instead of rereading them.
> 
> Signed-off-by: Rene Herman <rene.herman at gmail.com>
> ---
>  sound/pci/ac97/ac97_codec.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Well, it is still in that style just for laziness.  Changing to this
way requires the fix for 2.2/2.4 kernels, adding the chunk to the
patch, etc.

Anyway I'll apply it later.

Thanks,

Takashi

> 
> diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
> index 45fd290..4f4343d 100644
> --- a/sound/pci/ac97/ac97_codec.c
> +++ b/sound/pci/ac97/ac97_codec.c
> @@ -2015,8 +2015,8 @@ int snd_ac97_mixer(struct snd_ac97_bus *bus, struct snd_ac97_template *template,
>  
>  #ifdef CONFIG_PCI
>  	if (ac97->pci) {
> -		pci_read_config_word(ac97->pci, PCI_SUBSYSTEM_VENDOR_ID, &ac97->subsystem_vendor);
> -		pci_read_config_word(ac97->pci, PCI_SUBSYSTEM_ID, &ac97->subsystem_device);
> +		ac97->subsystem_vendor = ac97->pci->subsystem_vendor;
> +		ac97->subsystem_device = ac97->pci->subsystem_device;
>  	}
>  #endif
>  	if (bus->ops->reset) {
> -- 
> 1.5.5
> 


More information about the Alsa-devel mailing list