[alsa-devel] [PATCH] ALSA: re-order AC97 codec ID table.

Takashi Iwai tiwai at suse.de
Tue Jul 15 16:29:55 CEST 2008


At Tue, 15 Jul 2008 16:17:32 +0200,
Rene Herman wrote:
> 
> On 15-07-08 15:14, Takashi Iwai wrote:
> 
> > At Tue, 15 Jul 2008 03:23:55 +0200,
> > Rene Herman wrote:
> >> Hi Takashi.
> >>
> >> Feel free to drop if considered pointless churn but keeping it ordered 
> >> makes checking easier.
> > 
> > The idea is fine, but this breaks the current code...
> 
> Ah crap, sorry, completely failed to notice. Updated version attached, 
> also with the other trivial (whitespace and 'c' instead of 'C') changes 
> left out.
> 
> Perhaps to avoid another person helpfully screwing this up, it could be 
> somewhat useful to order the table down instead of up? In that case, the 
> order is just by ID without reference to the mask. If you feel that's 
> actually worth it, I'll go and shuffle the entire table around... :)

Well, I think it's enough to add comments appropriately.
Anyway, I applied this patch as is.  If you have more changes, please
post an incremental one.


thanks,

Takashi


More information about the Alsa-devel mailing list