[alsa-devel] [PATCH] ASoC: Fix warning from strict_strtoul()

Takashi Iwai tiwai at suse.de
Sat Jul 5 09:43:55 CEST 2008

At Fri, 4 Jul 2008 20:57:54 +0100,
Mark Brown wrote:
> On Fri, Jul 04, 2008 at 05:09:36PM +0200, Takashi Iwai wrote:
> > (BTW, at the next time, a bit more patch description would be helpful.
> >  For example, in this case, it's actually not about warning but the
> >  behavior of strict_strtoul() that resets the value, if I understand
> >  correctly.)
> It is a warning fix - I was passing the wrong type of variable to
> strict_strtoul(), though on most architectures int and long are the same
> in memory so the behaviour before and after the change is identical.
> The fix is to pass a temporary variable of the correct type in and then
> assign the result to pop_time rather than passing pop_time in directly.

Ah, OK, that I totally missed.

Anyway this also fixes another strange behavior - strict_strtoul()
stores 0 when it gets a parse error.  So, in the older version, the
pop_wait itself is reset to 0 at error while the value is kept in the
newer version.



More information about the Alsa-devel mailing list