[alsa-devel] [PATCH 2/2] wss: use stuct snd_wss instead of snd_ad1848

Takashi Iwai tiwai at suse.de
Thu Jul 3 14:46:44 CEST 2008

At Thu, 03 Jul 2008 12:42:00 +0200,
Rene Herman wrote:
> On 03-07-08 12:07, Takashi Iwai wrote:
> > At Tue, 1 Jul 2008 20:14:11 +0200,
> > Krzysztof Helt wrote:
> >> ---
> >> Another step toward unification of all WSS compatible
> >> chips handling.
> > 
> > Right, and without the unification, these patches have little merits.
> > So far, it's more addition than deletion in total.
> > [Your work is greatly appreciated, of course.  I just want to tell
> >  that it can't be applied alone without the unification.]
> Yes these should probably grow as a series with somewhat of a (semi-) 
> final result being apparent after applying patch N of N. I'm importing 
> Krzysztof' patches into a "wss" branch in my local git tree and will be 
> testing them as they come in though -- and frankly, I think it's better 
> if they come in as he does them a few at a time rather than a large 
> number at once as it's easier for review purposes.

Well, I can keep it in a branch if you prefer.  Just let me know.

> (by the way, Krzysztof, if them not being applied immediately anyway 
> means you'd rather work the series against for example current mainline 
> that's fine by me as well)
> > BTW, the first patch seems too big for ML, and it can't be applied as
> > is (wss.h doesn't exist, etc), in addition to missing Kconfig and 
> > Makefile changes.  Could you fix and split to several patches?
> They depended on his first two patches:
> http://mailman.alsa-project.org/pipermail/alsa-devel/2008-June/008766.html
> http://mailman.alsa-project.org/pipermail/alsa-devel/2008-June/008669.html
> But as far as I'm concerned you could just sit back until the series is 
> somewhat "complete".

OK.  As 2.6.26 will come out soon, it's a bit too late to include
such a big change for 2.6.27.  So we have still some time :)



More information about the Alsa-devel mailing list