[alsa-devel] [PATCH 2/2] wss: use stuct snd_wss instead of snd_ad1848

Takashi Iwai tiwai at suse.de
Thu Jul 3 12:07:33 CEST 2008

At Tue, 1 Jul 2008 20:14:11 +0200,
Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> The snd_wss is superset of the snd_ad1848 so kill
> the latter and replace it with the snd_wss.
> Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
> ---
> Another step toward unification of all WSS compatible
> chips handling.

Right, and without the unification, these patches have little merits.
So far, it's more addition than deletion in total.
[Your work is greatly appreciated, of course.  I just want to tell
 that it can't be applied alone without the unification.]

BTW, the first patch seems too big for ML, and it can't be applied as
is (wss.h doesn't exist, etc), in addition to missing Kconfig and
Makefile changes.  Could you fix and split to several patches?
For this kind of large changes, you should really use git.  Then we
can track file-renaming well, too.



More information about the Alsa-devel mailing list