[alsa-devel] [PATCH] Add better checks for pastebin.ca availability

[Takashi Iwai]

At Wed, 02 Jul 2008 00:52:14 +1000,
Travis Place wrote:
> 
> At the moment, it seems that a) pastebin.ca (the host) is UP, and b) the
> WEB SERVER on it is DOWN.
> 
> So ive implemented (even if messy) an extra check for this scenario.
> I would consider using another pastebin service, but we have it pretty
> good with slepp (the pastebin.ca owner) as he has allowed us to have our
> own paste 'type' (which enables the areas to collapse, highlighting of
> certain things, etc).
> 
> Changelog: Added an extra check to see if the Web Server is functioning
> on our pastebin service. Now we check that the host is up, and the
> webserver itself is alive.
> 
> Patch Attached.
> 
> Signed-off-by: Travis Place <wishie at wishie.net>

The change looks fine, but any reason to use [[..]]] instead of normal
test or [ ?


thanks,

Takashi


> [2 alsa-info.patch-0.4.49 <text/x-patch; UTF-8 (7bit)>]
> --- alsa-info.sh	2008-07-02 00:43:36.000000000 +1000
> +++ alsa-info.sh.wishie	2008-07-02 00:44:10.000000000 +1000
> @@ -1,6 +1,6 @@
>  #!/bin/bash
>  
> -SCRIPT_VERSION=0.4.48
> +SCRIPT_VERSION=0.4.49
>  CHANGELOG="http://www.alsa-project.org/alsa-info.sh.changelog"
>  
>  #################################################################################
> @@ -32,8 +32,17 @@
>  PASTEBINKEY="C9cRIO8m/9y8Cs0nVs0FraRx7U0pHsuc"
>  #Define some simple functions
>  
> +pbweb(){
> +[[ $(wget http://pastebin.ca/index.php &> /dev/null) ]] || KEEP_FILES="yes" NOUPLOAD="yes" PBERROR="yes" 
> +}
> +
>  pbcheck(){
> -	[[ $(ping -c1 www.pastebin.ca) ]] || KEEP_FILES="yes" NOUPLOAD="yes" PBERROR="yes"
> +if [[ $(ping -c1 www.pastebin.ca) ]]
> +then
> +pbweb
> +else
> +KEEP_FILES="yes" NOUPLOAD="yes" PBERROR="yes"
> +fi
>  }
>  
>  update() {