[alsa-devel] [PATCH] Add missing additional verbs for SPDIF with AD1984 & thinkpad

Takashi Iwai tiwai at suse.de
Sat Jan 26 10:05:00 CET 2008


At Fri, 25 Jan 2008 20:04:40 -0600,
Jerone Young wrote:
> 
> Additional verbs are missing for IEC958 code for the AD1984 in
> thinkpads. This is identical to the verbs in AD19884. I missed these
> in my patch last month.
> 
> Signed-off-by: Jerone Young <jerone at gmail.com>

Are you sure that you need this?  ad1984_thinkpad_init_verbs is the
*additional* verbs to ad1884_init_verbs.  The same sequence is already
found in ad1884_init_verbs, so it looks just doubled.


Takashi

> 
> diff -r dcc1b9d533d3 alsa-kernel/pci/hda/patch_analog.c
> --- a/alsa-kernel/pci/hda/patch_analog.c	Fri Jan 25 19:49:19 2008 -0600
> +++ b/alsa-kernel/pci/hda/patch_analog.c	Fri Jan 25 19:51:05 2008 -0600
> @@ -3188,6 +3188,9 @@ static struct hda_verb ad1984_thinkpad_i
>  	{0x20, AC_VERB_SET_AMP_GAIN_MUTE, AMP_IN_MUTE(4)},
>  	/* enable EAPD bit */
>  	{0x12, AC_VERB_SET_EAPD_BTLENABLE, 0x02},
> +	/* SPDIF output selector */
> +	{0x02, AC_VERB_SET_CONNECT_SEL, 0x0}, /* PCM */
> +	{0x1b, AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE | 0x27}, /* 0dB */
>  };
> 
>  /* Digial MIC ADC NID 0x05 + 0x06 */
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 


More information about the Alsa-devel mailing list