[alsa-devel] es1938 - patch trying to improve capture hw pointer reads
Hermann.Lauer at iwr.uni-heidelberg.de
Thu Jan 24 16:21:02 CET 2008
On Thu, Jan 24, 2008 at 12:47:46PM +0100, Takashi Iwai wrote:
> Thanks for the patch.
> The change look OK to me. Another idea would be to use DMAADDR only
> when DMACOUNT goes mad.
The problem is to decide when you have read garbage from DMACOUNT.
DMAADDR is better in the first place, because you know the range
in 24 bit which is valid (DMACOUNT is 16bit only). But my patch tries
to make the failure probability much more lower by reading and comparing
both, so from which one you calculate the pointer at the end is only
a cosmetic issue.
> But the back-off to the last pointer is
> propbably a safer solution.
I'm glad to hear the alsa design allow's this trick - or is
that even the recommeded way to deal with when the hardware pointer
could be temporarily not determined ?
> The patch is, however, unable to apply as is because of coding style
> problems. Try $LINUXKERNEL/scripts/checkpatch.pl, fix what are
> suggested there, and repost the patch together with your sign-off.
Will do that when I digged trough the details (have to learn about signing).
Netzwerkadministration/Zentrale Dienste, Interdiziplinaeres
Zentrum fuer wissenschaftliches Rechnen der Universitaet Heidelberg
IWR; INF 368; 69120 Heidelberg; Tel: (06221)54-8236 Fax: -5224
Email: Hermann.Lauer at iwr.uni-heidelberg.de
More information about the Alsa-devel