[alsa-devel] [PATCH] dapm_new_mixer and 32 bytes limitation

[Takashi Iwai]

At Mon, 21 Jan 2008 12:05:55 +0100 (CET),
Jaroslav Kysela wrote:
> 
> On Mon, 21 Jan 2008, Takashi Iwai wrote:
> 
> > At 18 Jan 2008 21:13:36 +0100,
> > Robert Jarzmik wrote:
> > > 
> > > diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> > > index ea20138..f22a1bb 100644
> > > --- a/sound/soc/soc-dapm.c
> > > +++ b/sound/soc/soc-dapm.c
> > > @@ -281,7 +281,7 @@ static int dapm_new_mixer(struct snd_soc_codec *codec,
> > >  	struct snd_soc_dapm_widget *w)
> > >  {
> > >  	int i, ret = 0;
> > > -	char name[32];
> > > +	char name[44];
> > 
> > Let's add a global const in asound.h instead of using a magic number
> > everywhere.
> 
> What about this:
> 
> 	int namelen = sizeof(w->kcontrols[0].name);

I thought of it, too, but it's too ugly, I'd say.


Takashi