[alsa-devel] [PATCH] hda: Added mono mux mixer for some STAC92HD7XXX family codecs

Takashi Iwai tiwai at suse.de
Sat Jan 19 10:40:53 CET 2008

At Fri, 18 Jan 2008 16:44:42 -0500,
Matthew Ranostay wrote:
> Some 92HD7XXX family codecs have a mono mux, added support for selecting the input path to the mono out.
> Signed-off-by: Matthew Ranostay <mranostay at embeddedalley.com>

Could you fix the coding-style issues reported by checkpatch.pl?

> +static struct hda_input_mux stac92hd71bxx_mono_mux = {
> +	/* count set later */

This is a bit dangerous.  In theory, we may have several hd-audio
instances, e.g. an on-board and a graphic card.  The local common
variable may conflict between two instances.  Rather copy the whole
input_mux to spec, and modify locally.



More information about the Alsa-devel mailing list