[alsa-devel] hdsp driver broken for Multiface II Rev 35

[Takashi Iwai]

At Tue, 15 Jan 2008 20:42:15 +0100,
Andreas Degert wrote:
> 
> On Mon, 14 Jan 2008 12:00:10 +0100
> Takashi Iwai <tiwai at suse.de> wrote:
> 
> [...]
> > > 
> > > static int hdsp_playback_to_output_key (struct hdsp *hdsp, int in,
> > > int out) {
> > >         switch (hdsp->io_type) {
> > >         case Multiface:
> > >         case Digiface:
> > >         default:
> > >                 if (hdsp->firmware_rev == 0xa)
> > >                         return (64 * out) + (32 + (in));
> > >                 else
> > >                         return (52 * out) + (26 + (in));
> > >         case H9632:
> > >                 return (32 * out) + (16 + (in));
> > >         case H9652:
> > >                 return (52 * out) + (26 + (in));
> > >         }
> > > }
> > 
> > This looks OK.  Could you prepare a patch (with a proper changelog and
> > your sing-off)?
> 
> ok, here it is:
> 
> hdsp: make Multiface II work again
> 
> This device has io_type == 1 (Multiface) and firmware_rev > 0xa
> (fixes regression from changeset 5326)
> 
> Signed-off-by: Andreas Degert <ad at papyrus-gmbh.de>

Applied to HG tree now.  Thanks!


Takashi