[alsa-devel] Splitting up the HDA-INTEL modules
jwoithe at physics.adelaide.edu.au
Tue Jan 15 23:56:39 CET 2008
Marco Schuster wrote:
> when I looked today through the files of the snd-hda-intel module, I
> was a bit shocked by this complex amount of code (patch_realtek.c for
> example). I would think about splitting up the code in a way each
> chipset gets its own .c file - which will make debugging, patching or
> editing a lot easier IMO, and for second people can then comment on
> just their specific chipset in config.
The problem with such a split is, as Tobin went on to say, that there are a
lot of interdependencies and shared code within each chipset's family:
> I don't think that it would be very easy, as there are several instances
> where code relies on other codec definitions.
One could argue that therefore we have toplevel realtek/sigmatek/etc
"librarys" which are used by each chipset-specific driver but IMHO that is
hardly going to count as a simplification.
Tobin then said:
> In all actuality, what is needed is a more generic driver that is driven
> by userspace tools. ... Maybe we can get a core group together and
> actually define and implement an API for this.
I think this idea has merit and may be worth pursuing. I would be
interested in assisting and providing input to the process although I
haven't time at present to take a lead role.
> My idea is a driver that takes settings from a config file that are
> either 32bit register values (aka Sigmatel), or individual Node
> parameters (Realtek, Conexant, etc). This way we can define model
> config files, and associate their PCI Quirk in a central config file
> that can be edited in userspace. This would be much easier to support,
> for users, distro vendors, hardware vendors, and us.
Agreed, at least in theory. There may be complications due to the varying
topography of the chips; the userspace API may have to be relatively
complex to support things like record source switch options (which are
vastly different for diffenent chips). Even so, if we can get this to work
the ongoing support effort for HDA will be much reduced so it's probably
worth the effort.
> I'll try to write up a proposal in the next few weeks, if we can get
> others on board to work on this.
I think this would be worth looking at.
More information about the Alsa-devel