[alsa-devel] [PATCH] ASoC drivers for the Freescale MPC8610 SoC

Grant Likely grant.likely at secretlab.ca
Thu Jan 10 21:24:10 CET 2008


On 1/10/08, Timur Tabi <timur at freescale.com> wrote:
> Jon Smirl wrote:
>
> > Isn't your codec is i2c controlled? Where does the main node for the
> > code live, i2c bus or ssi bus? What does the link between the buses
> > look like for pointing to the codec entry?
>
> The CS4270 driver is "old style", which means it probes all possible I2C
> addresses until it finds a hit, and then stops.  This has all the obvious
> drawbacks, but I'm stuck with that design for now.
>
> > What about fsl,ssi being too generic for a compatible type?
>
> Already fixed:
>
>                 ssi at 16000 {
>                         compatible = "fsl,mpc8610-ssi";

Nit: node name should be either i2s at 16000 (the mode that it is in), or
sound at 16000 (if you feel that this node encapsulates the concept of a
sound device enough).

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.


More information about the Alsa-devel mailing list