[alsa-devel] [PATCH] TWL4030: Add event callback to enable hands-free.

Mark Brown broonie at sirena.org.uk
Thu Dec 11 13:53:48 CET 2008

On Thu, Dec 11, 2008 at 09:52:01AM +0800, Stanley.Miao wrote:
> A special sequence is required to enable hands-free on TWL4030.
> Signed-off-by: Stanley.Miao <stanley.miao at windriver.com>

I've applied this but I'm a bit nervous about this:

> +	} else {
> +		twl4030_write(w->codec, e->reg, 0x0);
> +	}

since that's clearing bits other than those which were enabled.  It
looks like there aren't any other bits in the register but it'd be good
to be more explicit about this.

More information about the Alsa-devel mailing list