[alsa-devel] [PATCH] tlv320aic3x: control additions and cleanups

Mark Brown broonie at sirena.org.uk
Thu Dec 4 19:37:47 CET 2008

On Thu, Dec 04, 2008 at 06:51:21PM +0100, Daniel Mack wrote:

> - split "Line Playback Switch" into "LineL Playback Switch" and "LineR
>   Playback Switch"
> - split "Line PGA Bypass Playback Volume" into "LineL Left PGA Bypass
>   Playback Volume" and "LineR Right PGA Bypass Playback Volume"

I can't help thinking that it'd be easier to just use "Left Line" and
"Right Line" but that's an existing issue in the driver.

> Signed-off-by: Daniel Mack <daniel at caiaq.de>
> Signed-off-by: Uli Luckas <u.luckas at road.de>                                                                                                             
Did you write this patch or did Uli?  If you wrote it the line for Uli
should be an Acked-by, if he wrote it then your Signed-off-by should
come second and it should have a From: for him at the top.

The patch itself looks good.

More information about the Alsa-devel mailing list