[alsa-devel] [PATCH] tlv320aic3x: headset/button press support

Daniel Mack daniel at caiaq.org
Wed Dec 3 11:39:48 CET 2008

Hi Ben,

On Tue, Dec 02, 2008 at 07:50:19PM +0000, Mark Brown wrote:
> > There is different types of headsets supported by this chip (see page 42
> > of the datasheet), and this bits define which types the detection should
> > be enabled for.
> I *belive* it's a headset but please submit a patch adding some text
> documenting this, ideally people shouldn't have to refer to the
> datasheet to use the driver.

Ok, added some lines of comment in my new version. However, I strongly
believe that anyone who uses that chip needs to read the datasheet
carefully anyway as it is very versatile and full of pitfalls therefore.

> As I have repeatedly mentioned it would be very much better if you were
> to do your submissions in the standard fashion which is documented in
> Documentation/SubmittingPatches.

I'm switching over to git-format-patch now, hoping this tool does it
right. Sorry for the trouble, I didn't want to bother you.

Best regards,

More information about the Alsa-devel mailing list