[alsa-devel] [PATCH] ASoC: Add WM8903 CODEC driver

[Jean Delvare]

Hi Takashi,

On Tue, 26 Aug 2008 15:37:30 +0200, Takashi Iwai wrote:
> At Tue, 26 Aug 2008 15:28:56 +0200,
> Jean Delvare wrote:
> > On Tue, 26 Aug 2008 13:05:27 +0100, Mark Brown wrote:
> > > +	if (ret != 0) {
> > > +		dev_err(&pdev->dev, "can't add i2c driver");
> > 
> > Missing \n at end of string (looks like many other drivers have this
> > problem - I found 11 other cases under sound/soc, I can send a patch
> > fixing these if you want.)
> 
> It'd be appreciated.  If Mark didn't work on it yet, I'll merge them.

Incidentally, I am working on converting almost all the affected
drivers to the new i2c device driver binding model, and my conversion
changes that part of the code. So in order to avoid useless conflicts,
I'd rather not touch that part of the code in a separate patch. My
conversion patches will fix the strings as a side effect anyway.

I'll send a patch with 2 fixes affecting the drivers I am not going to
touch, so that these fixes aren't lost.

-- 
Jean Delvare