[alsa-devel] [PATCH] Try to make our poor little ALS4000 driver worthy of its copious public specs (first step)
tiwai at suse.de
Wed Aug 20 10:40:22 CEST 2008
At Tue, 19 Aug 2008 22:34:44 +0200,
Andreas Mohr wrote:
> there you have it: Linux developers are hypocrites ;)
> Never omitting any opportunity to complain about missing vendor
> cooperation, but what do they do once people actually do publish ample specs? -
> yeah, you got that right: NOTHING!!
> Let's try to change that, at least one bit at a time. ;)
> - use specs-derived register name enums instead of open-coded numeric
> values, for better understanding of things
> - fix naming confusion ("gcr" was _NOT_ the GCR register stuff, but
> instead the io _base_ which has multiplexed _access_ to GCR config
> space, at _sub_ registers 0x08 and 0x0c)
> - add FIXME comments about a race condition and MPU401 features
> Oh, and I chose an abbreviated "ALS4K" prefix since I would have gotten
> finger cramps otherwise.
> Patch created on 2.6.27-rc1-git4 (no als4000.c changes up to -rc3, verified),
> pushed through checkpatch.pl, verified on my ALS4000 card.
Thanks, applied now.
More information about the Alsa-devel