[alsa-devel] [Alsa-user] found bug, fixed bug, cannot tell anyone

[Takashi Iwai]

At Fri, 15 Aug 2008 09:19:59 +0200,
Rene Herman wrote:
> 
> On 14-08-08 22:36, Wesley Johnson wrote:
> 
> > BUG:
> > When you try to compile driver for ens1371 by itself the compile will fail.
> > The driver for ens1371 has an include of the file for ens1370, but the
> > makefule does not have this dependency
> > so the ens1370 file is missing.  The dev team is probably always compiling
> > for all.
> > 
> > Diff file that fixes this problem follows.
> > 
> > *** pci/Makefile.orig Mon Jul 14 02:53:57 2008
> > --- pci/Makefile Thu Jul 17 21:25:42 2008
> > ***************
> > *** 27,34 ****
> > --- 27,35 ----
> >   atiixp_modem.c: atiixp_modem.patch
> > $(SND_TOPDIR)/alsa-kernel/pci/atiixp_modem.c
> >   bt87x.c: bt87x.patch $(SND_TOPDIR)/alsa-kernel/pci/bt87x.c
> >   cmipci.c: cmipci.patch $(SND_TOPDIR)/alsa-kernel/pci/cmipci.c
> >   ens1370.c: ens1370.patch $(SND_TOPDIR)/alsa-kernel/pci/ens1370.c
> > + ens1371.c: ens1370.c
> 
> I expect this should be a straight copy of the ens1370.c line but never 
> use the standalone alsa-driver package. Now that we're on alsa-devel, 
> people who do will reply though.

The fix looks correct to me.  ens1371.c includes ens1370 with an
additional define.  So, it actually depends on it.


Takashi