[alsa-devel] [PATCH 2/2] wm8750: add missing VREF output

Takashi Iwai tiwai at suse.de
Mon Aug 11 17:08:06 CEST 2008


At Mon, 11 Aug 2008 18:16:28 +0400,
Dmitry Baryshkov wrote:
> 
> Hi,
> 
> Mark Brown wrote:
> > On Mon, Aug 11, 2008 at 12:37:45PM +0200, Takashi Iwai wrote:
> > 
> >> You mean both patches (spitz: MONO -> MONO1 and wm8750: add missing
> >> VREF)?  Anyway, a bit more detailed changelog is needed - what's
> >> broken in the real use and how fixed.
> > 
> > The long description is exactly what's broken - the names are wrong or
> > undeclared and since DAPM works based on the control names this causes
> > the drivers to fail to initialise DAPM for the device concerned.  It's
> > pretty much equivalent to C code referencing an undeclared variable.
> > 
> 
> I saw these patches got merged into asoc/dev tree. Should I repost them 
> with more descriptive changelog, or are them suitable as is?

I already merged the patch "wm8750: it's MONO1, not MONO", but other
two are still pending.  Please give some descriptions in the changelog
to each of these two patches and repost.


thanks,

Takashi


More information about the Alsa-devel mailing list