[alsa-devel] [PATCH 2/2] wm8750: add missing VREF output

Mark Brown broonie at sirena.org.uk
Mon Aug 11 13:01:00 CEST 2008

On Mon, Aug 11, 2008 at 12:45:32PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > The long description is exactly what's broken - the names are wrong or
> > undeclared and since DAPM works based on the control names this causes
> > the drivers to fail to initialise DAPM for the device concerned. 

> Exactly such a text should appear in the changelog.

Sure, my intention was to provide some appropriate text.

> > It's
> > pretty much equivalent to C code referencing an undeclared variable.

> Everyone knows C syntax but not ASoC implementation details.
> If the patch is pushed to stable tree, it should be described well so
> that other reviewers can understand it well.

Sorry, there may have been a miscommunication here - this should only
*need* to go to 2.6.27 since the bulk registration functions are more
careful about checking error values than the hand rolled loops tended to
be.  For earlier kernels people will either not notice or have already
have local patches so the bugs are not quite so serious.

Obviously, it'd be good to fix for the earlier kernels but it's not
clear it is critical enough for them.

More information about the Alsa-devel mailing list