[alsa-devel] Kill snd_assert()
perex at perex.cz
Mon Aug 11 10:52:23 CEST 2008
On Mon, 11 Aug 2008, Takashi Iwai wrote:
> as some people already mentioned, we have a pretty ugly macro, snd_assert().
> Actually, this macro is sometimes useful, but the implementation including
> the code flow in arguments is really bad.
> I tried to kill this, either the following way:
> - replace
> snd_assert(cond, flow...);
> if (snd_BUG_ON(!cond))
For my eyes, many uses of snd_assert with direct 'return VALUE' are more
"sexy", easy understandable and smaller. But, as mentioned, when goto is
used to change the code flow, we end up with a compiler warning. It should
I have no strong objections to accept this change as you proposed. Thank
you for your work.
Jaroslav Kysela <perex at perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.
More information about the Alsa-devel