[alsa-devel] [PATCH] ALSA: wss_lib: rework snd_ad1848_probe()

krzysztof.h1 at poczta.fm krzysztof.h1 at poczta.fm
Wed Aug 6 09:57:24 CEST 2008

> Hi Takashi.
> This reworks snd_ad1848_probe(), making for IMO significantly more 
> straightforward reading.
> The original had a somewhat odd try-loop where it not only waited for 
> the codec to come out of init but also retried a failed basic detect 
> which seems to not make sense. Except for that, the detection logic 
> should be unchanged.

Acked-by: Krzysztof Helt <krzysztof.h1 at wp.pl>

> I am by the way rather unsure what it is that the spin_lock is trying to 
> protect us from here. What's the error scenario if we just not take it? 
> We aren't live yet...
> Next step is folding this into snd_wss_probe() directly.

I would like to leave it separate as 1. End of this function is good check point of correct detection for ad1848 chips, 2. The snd_wss_probe() is long enough.
But I won't oppose it fiercely.


Tani Telefon!
Sprawdz >>>  http://link.interia.pl/f1ec0  

More information about the Alsa-devel mailing list