[alsa-devel] [PATCH] ALSA: wss_lib: rework snd_ad1848_probe()

Rene Herman rene.herman at keyaccess.nl
Wed Aug 6 08:42:08 CEST 2008

Hi Takashi.

This reworks snd_ad1848_probe(), making for IMO significantly more 
straightforward reading.

The original had a somewhat odd try-loop where it not only waited for 
the codec to come out of init but also retried a failed basic detect 
which seems to not make sense. Except for that, the detection logic 
should be unchanged.

I am by the way rather unsure what it is that the spin_lock is trying to 
protect us from here. What's the error scenario if we just not take it? 
We aren't live yet...

Next step is folding this into snd_wss_probe() directly.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-ALSA-wss_lib-rework-snd_ad1848_probe.patch
Url: http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20080806/9057796d/attachment-0001.bat 

More information about the Alsa-devel mailing list