[alsa-devel] [PATCH 1/4] soc - neo1973_wm8753.c cleanup checkpatch issues

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Apr 30 17:47:27 CEST 2008

On Wed, Apr 30, 2008 at 05:36:40PM +0200, Takashi Iwai wrote:

> Applied all 4 patches now.


> I think we can push checkpatch clean-up patches to 2.6.26 if
> possible.  In addition, neo1973_wm8753.c suspend/resume/shutdown hooks
> look OK for 2.6.26.

Yes, and in fact this is a bug fix - without this code the device burns
an excessive amount of power while suspended.

> I'll keep Daniel's clock-setup change and GPIO support patches as
> post-2.6.26.

I agree.

> The addition of snd_soc_dapm_get_endpoint_status() appears to be a
> post-2.6.26, too, as there is no user yet on 2.6.26.

Yes, there's no user - the GTA02 is the only existing user and it can't
be merged since the underlying machine support is not integrated yet.
On the other hand, since there are no users it's very low risk :)
Either way is fine by me, anyway.

More information about the Alsa-devel mailing list