[alsa-devel] [PATCH] asoc tlv320aic3x: set power bits correctly

[Mark Brown]

On Wed, Apr 30, 2008 at 03:11:06PM +0200, Daniel Mack wrote:

> Hmm, ok - I might have a lack of knowledge here. All I was seeing with  
> an I2C hardware analyzer is that those registers in question were  
> written without the power bit set which makes them remain muted.  
> What's the way to power up this entity properly?

You need to ensure that the entire DAPM path from the DAC to the output
is powered by ensuring that the final output endpoint is marked as
active.  Your machine driver should be using snd_soc_dapm_set_endpoint()
to mark either the output pin of the codec or any external device (eg, a
jack) that you've told DAPM about as enabled.  If you do not do this
then DAPM will notice that none output paths are connected and not power
on any of the components in the output path in order to save power.

This should be integrated with any jack detection you are doing so that,
for example, the headphone output will be marked as disabled when there
is no headphone present.  The core will automatically manage the power
state for DACs and ADCs but the machine driver needs to manage the power
state for everything else.

> And as we're on it - aic3x_dapm_event(SNDRV_CTL_POWER_D3cold) is  
> called shortly after PCM playback has finished which clears the power  
> bits of many registers. This in turn also makes the current PGA mixer  
> setting become unfunctional as the outputs are switched off. Is there  
> a proper way of preventing the glue layer to power down the chip in  
> this case?

Are you sure about that?  The chip should only be being placed into
D3cold when the system is being suspended or powered off.  The chip will
be placed into D3hot when the DACs and ADCs go idle but not D3cold.
You will see similar behaviour if you haven't marked appropriate
endpoints as active (since DAPM will power off anything it thinks is not
in use, triggered when the DAC or ADC goes idle) but it shouldn't be
done by the driver D3cold.