[alsa-devel] [PATCH 1/3] asoc tlv320aic3x: revisit clock setup

Daniel Mack daniel at caiaq.org
Fri Apr 25 12:18:01 CEST 2008

On Fri, Apr 25, 2008 at 12:55:23PM +0300, Jarkko Nikula wrote:
> Did you forgot to take into account doubled fsref below (from the first
> version) when calculating codec_clk because now it is doubled earlier?

Oops, yes, you're right. Sorry for that.

> +        /* printk(KERN_INFO "%s(): bypassing PLL with Q=%d\n",
> +            __func__, pll_q); */
> I forgot to mention in my previous comment that KERN_DEBUG would be better
> here or just remove the printk.

Ok, did some error handling with a printk() instead.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: alsa-tlv320aic33-clocking.diff
Type: text/x-diff
Size: 8980 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20080425/926ad33d/attachment.bin 

More information about the Alsa-devel mailing list