[alsa-devel] [PATCH 002b/003] snd-powermac: style awacs.s and awacs.h

Takashi Iwai tiwai at suse.de
Wed Apr 16 12:39:59 CEST 2008


At Wed, 16 Apr 2008 13:35:42 +0300,
Risto Suominen wrote:
> 
> 2008/4/16, Takashi Iwai <tiwai at suse.de>:
> >
> > Hmm..  I get patch errors in 002b, 003a and 003b due to line folds.
> >  Could you resend?  Attachments would be fine to me, too.
> >
> 
> Ok, let's try...

Thanks, that works.  But, I get checkpatch errors:

ERROR: do not use assignment in if condition
#116: FILE: ppc/awacs.c:704:
+		if ((err = snd_ctl_add(chip->card,

ERROR: do not use assignment in if condition
#171: FILE: ppc/awacs.c:982:
+		if ((err = build_mixers(chip,

ERROR: do not use assignment in if condition
#191: FILE: ppc/awacs.c:999:
+		if ((err = build_mixers(chip,


Please fix?

Takashi


More information about the Alsa-devel mailing list