[alsa-devel] [PATCH 1/3] soc - pxa2xx-ac97: Add missing clk_enable()

eric miao eric.y.miao at gmail.com
Tue Apr 15 13:32:39 CEST 2008


It looks a bit confused between the commit message and the actual change.
My understanding would be the pxa{25x,27x} requires this change (adding
clk_enable), but pxa3xx does not require this. So actually the change is
addressing some issue on pxa{25x,27x}?

On Mon, Apr 14, 2008 at 11:12 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> For some reason this is not required on PXA3xx.
>
>  Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
>  ---
>   sound/soc/pxa/pxa2xx-ac97.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
>  diff --git a/sound/soc/pxa/pxa2xx-ac97.c b/sound/soc/pxa/pxa2xx-ac97.c
>  index fe9c297..e173799 100644
>  --- a/sound/soc/pxa/pxa2xx-ac97.c
>  +++ b/sound/soc/pxa/pxa2xx-ac97.c
>  @@ -314,6 +314,7 @@ static int pxa2xx_ac97_probe(struct platform_device *pdev)
>                 ac97_clk = NULL;
>                 goto err_irq;
>         }
>  +       clk_enable(ac97_clk);
>         return 0;
>
>   err_irq:
>  --
>  1.5.5
>
>



-- 
Cheers
- eric


More information about the Alsa-devel mailing list