[alsa-devel] [PATCH] New Aztech Sound Galaxy driver
tiwai at suse.de
Thu Sep 20 14:51:16 CEST 2007
At Thu, 20 Sep 2007 14:20:01 +0200,
Rene Herman wrote:
> lib.c was split off in preparation of having snd-azt2320 use it as well and
> generally containing non soundgalaxy specific code that might at some point
> make it into an isa/lib.c or something. It's tiny, so it's not constructed
> as a helper module but simply compiled into both drivers.
This doesn't work if both modules can be loaded at the same time in
theory. You'll get symbol crashes. To avoid this, make all functions
static and include from both, or make it a library module.
Also, avoid symbols like __xxx() as much as possible. These are
basically for compiler internals, so this might have problems in the
future version of compiler.
Otherise the code look fine, so far.
> [ all of the above is intended as a changelog ]
> Given that they are new drivers with new names, they shouldn't disturb
> anything and can as far as I'm concerned make 1.0.15 but if you feel it's
> too late (and/or don't want the two seperate drivers), so be it. I can also
> submit a next patch removing the old sgalaxy driver now or just wait with
> that one...
Well, I feel we can work better on this after 1.0.15. RC standas for
release-candiate, after all :)
More information about the Alsa-devel