[alsa-devel] [PATCH] ad1848-lib: remove open_mutex

Takashi Iwai tiwai at suse.de
Wed Sep 19 21:53:07 CEST 2007

At Wed, 19 Sep 2007 18:06:31 +0200,
Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> This patch removes open_mutex from the ad1848-lib as
> open and close operations are called only from pcm layer
> and mutexed there with pcm->open_mutex.
> Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
> ---
> Another step into crusade against the ad1848-lib. Inspired by
> Trent's comments about missing locking I have checked and
> open and close operations are already mutexed in the pcm layer
> by similarly called pcm->open_mutex. The OSS pcm layer
> also uses the pcm->open_mutex.
> Is it right thing to do? (Takashi, Jaroslav)?

Yes, it looks fine.
But, I'd like to postpone after 1.0.15.  OK?



More information about the Alsa-devel mailing list