[alsa-devel] [PATCH] ad1848 ac loop

Trent Piepho xyzzy at speakeasy.org
Wed Sep 19 07:22:42 CEST 2007

New thread for the the final version of the patches for my fixes to the ad1848
auto-calibration loop.  I made a couple suggested changes.  These should be ok
to apply, and should be independent of the other as yet un-applied patches
that have been posted by Rene and Krzysztof.

I'm not an expert on this chip by any means, but from looking at the code I
think there are few things that could be fixed.

The reg_lock spinlock isn't acquired from the irq handler, as the handler
doesn't use any of the indirect registers.  I think this means that is isn't
necessary to use the irq disabling versions of the spin_lock functions with

It does look like there is a different SMP race condition wrt the irq handler.

More information about the Alsa-devel mailing list